Skip to content
This repository was archived by the owner on Feb 22, 2018. It is now read-only.

feat(debug): Make ngProbe accept a CSS selector #970

Closed
wants to merge 1 commit into from

Conversation

vicb
Copy link
Contributor

@vicb vicb commented Apr 28, 2014

I think this could be a handy shortcut while debugging.

Thoughts ?

@jbdeboer
Copy link
Contributor

I like it.

This PR is missing tests, though.

@vicb
Copy link
Contributor Author

vicb commented Apr 28, 2014

I've tried to write some tests but _.compile does not assign the dom to the document. Any idea on how I could do ?

@vicb vicb added cla: yes and removed cla: no labels Apr 28, 2014
@mhevery
Copy link
Contributor

mhevery commented Apr 30, 2014

I have add a test.

vicb added a commit that referenced this pull request Apr 30, 2014
vicb added a commit that referenced this pull request Apr 30, 2014
@vicb vicb closed this in eb057c3 Apr 30, 2014
vicb added a commit that referenced this pull request Apr 30, 2014
vicb added a commit that referenced this pull request Apr 30, 2014
@vicb vicb deleted the 0428-debug branch May 1, 2014 08:53
@vicb
Copy link
Contributor Author

vicb commented May 1, 2014

thanks for the test

dsalsbury pushed a commit to dsalsbury/angular.dart that referenced this pull request Jul 16, 2014
dsalsbury pushed a commit to dsalsbury/angular.dart that referenced this pull request Jul 16, 2014
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Development

Successfully merging this pull request may close these issues.

3 participants